Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken doctest #71

Closed
wants to merge 3 commits into from

Conversation

fingolfin
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (64c6f29) to head (6c9e7f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files           8        8           
  Lines         739      739           
=======================================
  Hits          672      672           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Contributor Author

I did this before in PR #35 which you merged ... and then reversed... This time I added a comment to docs/make.jl that explain how it works. I hope this time it'll stick.

And maybe next time ask questions if you can't figure out how something works, it's not as if our offices were, like, next to each other :-). We also have plenty other people who know about Julia and can help. And we have a Slack (which you have joined before, I think? Otherwise see https://oscar-system.org/slack ) which is a great place to get advise. And then of course that's just OSCAR specific, there is a Julia Slack, discourse, and many more resources were you can learn and get support.

@blociss blociss closed this Mar 6, 2024
@fingolfin
Copy link
Contributor Author

I find your actions very confusing especially since you almost never explain them :-(. Like now: you approve but then don't merge but instead close the PR? Why?

in the meantime you changed the CI code to use docs/makelocal.jl -- clearly this is incompatible with this PR. It also is odd to me, because that file, as its name suggests, was/is for local use, not on a (remote) CI server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants