Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix documentation tests #35

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

fingolfin
Copy link
Contributor

Please let's first see if this actually fixes the error...

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e12d8a) 90.72% compared to head (9fed584) 90.72%.
Report is 1 commits behind head on main.

❗ Current head 9fed584 differs from pull request most recent head 10c55bf. Consider uploading reports for the commit 10c55bf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files           8        8           
  Lines         701      701           
=======================================
  Hits          636      636           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin marked this pull request as draft January 31, 2024 13:51
@blociss blociss closed this Jan 31, 2024
@fingolfin
Copy link
Contributor Author

UH, why close this, can you reopen? Just don't merge it for now

@blociss blociss reopened this Jan 31, 2024
@fingolfin fingolfin marked this pull request as ready for review January 31, 2024 18:19
@fingolfin
Copy link
Contributor Author

@blociss this successfully fixes the documentation CI test, so you could merge it.

But all the CI tests don't help you if you don't monitor their status. The most reliable way to achieve that is by making all changes through pull requests. If you do direct pushes, you must remember to at least on occasion check the CI status manually.

@blociss blociss merged commit 0cad09a into singular-gpispace:main Feb 1, 2024
2 checks passed
@fingolfin fingolfin deleted the mh/ci-doctest branch February 1, 2024 12:23
@fingolfin fingolfin mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants