Issue 224: Ensure Claim does not fail even when group ID changes #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge latest in to version
Ensure Group ID check should only apply at the time of storing channel state in etcd for the first time Moved the group ID check from BlockchainChannelReader to lockingPaymentChannelService.PaymentChannel()
|
@astroseger , tested this , works fine with claim now @vsbogd , request your review on this |
vsbogd
reviewed
Apr 3, 2019
| @@ -280,3 +281,41 @@ func (suite *PaymentChannelServiceSuite) TestStartClaim() { | |||
| assert.Equal(suite.T(), suite.payment(), claim.Payment()) | |||
| assert.Equal(suite.T(), []*Payment{suite.payment()}, claims) | |||
| } | |||
|
|
|||
| func (suite *PaymentChannelServiceSuite) TestVerifyGroupId() { | |||
| //Group ID check is only done for the first time , when the channel is added to storage from the block chain , | ||
| //if the channel is already present in the storage the group ID check is skipped. | ||
| if blockchainChannel != nil { | ||
| blockChainGroupID,err := h.blockchainReader.replicaGroupID() |
There was a problem hiding this comment.
As replicaGroupId is not used in blockchain reader anymore I would move it into lockingPaymentChannelService itself. But it will probably require fixing unit tests, so it makes sense to do separate PR for this.
There was a problem hiding this comment.
Will submit a separate PR by tomorrow , hopefully by then this is approved :)
…vate ( from VerifyGroupId to verifygroupId)
…bute to test the scenario in hand Simplified the test case by making it more readable (code review comments)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#224
Ensure Group ID check should only apply at the time of storing channel state in etcd for the first time
Moved the group ID check from BlockchainChannelReader to lockingPaymentChannelService.PaymentChannel()