Support contract Changes on Using Organization Id and Service Id #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of Organization name and Service Name. We will need to clean up the daemon configuration generation across all wikis / README.md files to reflect this configuration change correctly aswell.
|
The build will fail as the latest contract is not available for reference at 0.2.4 |
|
Looks good to me, as singnet/platform-contracts#85 is merged already, could you please replace release version at to make it buildable |
…gnature change of method MultiPartyEscrow.OpenChannel
|
Thanks @vsbogd , pointing to the latest contract now. |
raamb
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support contract Changes on Using Organization Id and Service Id instead of Organization name and Service Name.
We will need to clean up the daemon configuration generation across all wikis / README.md files to reflect this correctly.