feat(server): Add support for nonce #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, was about to do this one myself as we're also in need of it. Currently we keep that script snippet empty and "live" with the csp violation logged in the browser. Do you have time to add tests for it? |
* feat: pass the error as a prop when mounting error UIs * Add test Co-authored-by: joeldenning <[email protected]>
Co-authored-by: guido.gasper <[email protected]>
joeldenning
approved these changes
Jun 7, 2022
|
Documented in single-spa/single-spa.js.org#553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to specify an
nonceattribute for the<script>tag injected bysendLayoutHTTPResponse.This script tag being crucial to single-spa, it's currently impossible to use it with a strict CSP. We're currently using it in production, but we need to search the whole output and replace
<script>with<script nonce="...">, not an optimal solution.Another approach to solve this would be to prevent the browser from evaluating this script tag (by setting a
typedifferent than a javascript mime type), and then manually read from it in single-spa's client script.