Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Iterate on spatial + readthedocs #3608

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jan 22, 2025

Issue and/or context: #3606 was nice, but, readthedocs failed at https://app.readthedocs.org/projects/tiledbsoma/builds/26927429/ with

/home/docs/checkouts/readthedocs.org/user_builds/tiledbsoma/checkouts/latest/apis/python/src/tiledbsoma/io/spatial/outgest.py:16: UserWarning: Experimental spatial outgestor requires the spatialdata package.
  warnings.warn("Experimental spatial outgestor requires the spatialdata package.")
WARNING: Failed to import tiledbsoma.io.spatial.
...
* ModuleNotFoundError: No module named 'spatialdata'
* AttributeError: module 'tiledbsoma.io' has no attribute 'spatial'
...

Changes:

Add in the spatialdata dependency to doc/requirements_doc.txt

Notes for Reviewer:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (c515933) to head (3d801f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3608      +/-   ##
==========================================
+ Coverage   86.26%   86.31%   +0.04%     
==========================================
  Files          55       55              
  Lines        6378     6378              
==========================================
+ Hits         5502     5505       +3     
+ Misses        876      873       -3     
Flag Coverage Δ
python 86.31% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.31% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 662293e into main Jan 22, 2025
17 checks passed
@johnkerl johnkerl deleted the kerl/fix-spatial-docs-more-fixier branch January 22, 2025 00:31
johnkerl added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants