[python] Throw error in SOMAVFSFilebuf.open on file-not-found
#3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3565 +/- ##
==========================================
+ Coverage 86.22% 86.27% +0.04%
==========================================
Files 55 55
Lines 6410 6410
==========================================
+ Hits 5527 5530 +3
+ Misses 883 880 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
SOMAVFSFilebuf.open if file DNESOMAVFSFilebuf.open on file-not-found
johnkerl
approved these changes
Jan 15, 2025
Co-authored-by: John Kerl <[email protected]>
nguyenv
deleted the
viviannguyen/sc-61909/misleading-error-message-in-soma-ingestor
branch
johnkerl
pushed a commit
that referenced
this pull request
Jan 16, 2025
… (#3569) Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
[sc-61909]
Changes:
Fix misleading error by throwing an explicit error in
SOMAVFSFilebuf.openif the file does not exist.