Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] tiledbsoma.__init__.py: restore lint checks #3495

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

ryan-williams
Copy link
Member

Flagged in #3476 (comment).

# ruff: noqa midway through the file was actually turning off ruff for the whole file.

This replaces that with a couple of more specific ruff rule disables, which only apply to relevant sections.

@ryan-williams ryan-williams marked this pull request as ready for review December 20, 2024 16:27
@ryan-williams ryan-williams changed the title tiledbsoma.__init__.py: restore lint checks [python] tiledbsoma.__init__.py: restore lint checks Dec 20, 2024
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryan-williams !

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (dcbdba2) to head (416c33a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
+ Coverage   86.27%   86.32%   +0.04%     
==========================================
  Files          55       55              
  Lines        6338     6338              
==========================================
+ Hits         5468     5471       +3     
+ Misses        870      867       -3     
Flag Coverage Δ
python 86.32% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.32% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants