[python] Make ExperimentAxisQuery inherit somacore, restore its .close
#3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
ExperimentAxisQuery inherit somacore, restore its .close
johnkerl
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Please restore test_query_cleanup from
https://github.com/single-cell-data/TileDB-SOMA/blob/1.14.5/apis/python/tests/test_experiment_query.py#L541-L567
but omitting the threadpool-is-None/not-None checks per
#3307 (comment)
We need unit-test coverage that we have a .close method on ExperimentAxisQuery
Co-authored-by: John Kerl <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
….close` (#3493) * make EAQ inherit somacore, restore EAQ.close * restore `test_query_cleanup` sans threadpool checks * Update apis/python/src/tiledbsoma/_query.py Co-authored-by: John Kerl <[email protected]> --------- Co-authored-by: John Kerl <[email protected]>
johnkerl
added a commit
that referenced
this pull request
Dec 20, 2024
….close` (#3493) (#3500) * make EAQ inherit somacore, restore EAQ.close * restore `test_query_cleanup` sans threadpool checks * Update apis/python/src/tiledbsoma/_query.py --------- Co-authored-by: Ryan Williams <[email protected]> Co-authored-by: John Kerl <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3493 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.05%
==========================================
Files 55 55
Lines 6338 6340 +2
==========================================
+ Hits 5468 5473 +5
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
somacore, but mistakenly didn't inherit from thesomacore.ExperimentAxisQueryABC.ExperimentAxisQuery.closea no-op (per this thread).ExperimentAxisQuery.closealtogether, which should have triggered a pre-commit error since EAQ was no longer implementing thesomacoreABC.closeto fail pre-commit.[sc-59686]