[c++, python] fastercsx: improved duplicate coordinate handling
#3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3468 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.04%
==========================================
Files 55 55
Lines 6339 6338 -1
==========================================
+ Hits 5469 5471 +2
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
fastercsx: improved duplicate coordinate handling
johnkerl
pushed a commit
that referenced
this pull request
Dec 19, 2024
) (#3485) * improved duplicate coordinate handling * invert sense of dup flag * fix mishandled empty first fragment in compress_coo * pr fb * fix race Co-authored-by: Bruce Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
the
fastercsxmodule will generate a malformed scipy sparse matrix under a specific set of conditions not usually seen with SOMA data (matrix contains duplicate coordinates). This PR detects that condition and correctly initializes the SciPy sparse matrix. Tested on scipy==1.15.0r1 for good measure.Changes:
from_pjdmethod)