[c++] Set overriding user-provided prefix to be off by default #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is surprising to override standard input variables. This requires the user to actively opt-in to overriding the standard CMake behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3463 +/- ##
==========================================
+ Coverage 86.24% 86.29% +0.04%
==========================================
Files 55 55
Lines 6305 6305
==========================================
+ Hits 5438 5441 +3
+ Misses 867 864 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
changed the title
johnkerl
changed the title
nguyenv
approved these changes
Dec 19, 2024
johnkerl
approved these changes
Dec 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
It is surprising to override standard input variables. This requires the user to actively opt-in to overriding the standard CMake behavior.
johnkerl
pushed a commit
that referenced
this pull request
Dec 19, 2024
It is surprising to override standard input variables. This requires the user to actively opt-in to overriding the standard CMake behavior. Co-authored-by: Julia Dark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CMake
OVERRIDE_INSTALL_PREFIXto be off by default so that theCMAKE_INSTALL_PREFIXis not overridden when building directly from CMake. The previous behavior is surprising when building libtiledbsoma directly from CMake. The behavior of theMakefileand the Bash and PowerShellbldscripts are unchanged.Note: this primarily impacts developer experience for those developers who invoke
cmakedirectly. No impact is expected for our CI or build systems.