-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python,c++] Improve error handling in IntIndexer
#3441
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3441 +/- ##
==========================================
+ Coverage 86.22% 86.29% +0.06%
==========================================
Files 55 55
Lines 6295 6305 +10
==========================================
+ Hits 5428 5441 +13
+ Misses 867 864 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
IntIndexer
IntIndexer
IntIndexer
What is the purpose of adding |
It tells pybind to not try and cast, which removes all kinds of unsupported things (i.e., likely errors) from being done implicitly. Pybind will try to cast almost any sequence to an ndarray. If we don't explicitly need that behavior, it is better to just disable it. |
* improve error handling in reindexer/IntIndexr * improve error handling in reindexer/IntIndexr * refine exceptions * lint * lint * fix mishandling of arrow array input * add test
* improve error handling in reindexer/IntIndexr * improve error handling in reindexer/IntIndexr * refine exceptions * lint * lint * fix mishandling of arrow array input * add test Co-authored-by: Bruce Martin <[email protected]>
Issue and/or context:
IntIndexer would do strange things when given malformed inputs. See for example sc-60689 and sc-60690
IntIndexer also incorrectly handled any arrow array with an offset, and would return incorrect outputs. See sc-60795
Changes: