Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Spatial changes required for somacore 1.0.24 #3333

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 18, 2024

Update the spatial changes to match changes to the somacore API.

Changes:

  • Add optional parameter coordinate_space to Scene.create.
  • Remove index_column_names from PointCloudDataFrame.createandGeometryDataFrame.create`.

@jp-dark jp-dark force-pushed the dark/somacore-1.0.24 branch from 7559cc4 to a5a88fb Compare November 18, 2024 20:57
@jp-dark
Copy link
Collaborator Author

jp-dark commented Nov 18, 2024

sc-58127

@ryan-williams ryan-williams force-pushed the rw/sc branch 2 times, most recently from 9ab54e2 to 3017ad8 Compare November 19, 2024 18:03
Base automatically changed from rw/sc to main November 19, 2024 19:28
@jp-dark jp-dark requested review from johnkerl and nguyenv November 19, 2024 19:29
@jp-dark jp-dark force-pushed the dark/somacore-1.0.24 branch from a5a88fb to fa6cef2 Compare November 19, 2024 19:30
It now takes `coordinate_space` as an optional parameter. (Throws not
implemented for now.)
Remove ``index_column_names`` from spatial data ``create`` methods. For
now, the user must always use the spatial axes for indexing.
@jp-dark jp-dark force-pushed the dark/somacore-1.0.24 branch from fa6cef2 to 530c8f8 Compare November 19, 2024 20:20
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.76%. Comparing base (cde6da1) to head (530c8f8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
+ Coverage   85.71%   85.76%   +0.04%     
==========================================
  Files          57       57              
  Lines        6169     6180      +11     
==========================================
+ Hits         5288     5300      +12     
+ Misses        881      880       -1     
Flag Coverage Δ
python 85.76% <72.22%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.76% <72.22%> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@jp-dark jp-dark merged commit 8840de0 into main Nov 19, 2024
21 checks passed
@jp-dark jp-dark deleted the dark/somacore-1.0.24 branch November 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants