Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r/ci] Try to unbreak r-valgrind CI #3318

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 8, 2024

Issue and/or context: #3315 [sc-59088]

Changes: With #3313 in place to avoid the problematic (default) truncation to 13 lines of output, I ran https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11744677785/job/32720341469 and saw

2024-11-08T15:36:21.1886016Z   **4849** new/new[] failed and should throw an exception, but Valgrind
2024-11-08T15:36:21.1887203Z   **4849**    cannot throw exceptions and so is aborting instead.  Sorry.

I'm imitating a memory config from other R CI YAMLs in our project in hopes this will help.

Notes for Reviewer:

Manual r-valgrind run (since that CI doesn't run on every PR):
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11745362897

Note we have another active R CI failure (unrelated) #3314 which is muddying the waters.

@johnkerl johnkerl requested a review from mojaveazure November 8, 2024 15:56
@johnkerl
Copy link
Member Author

johnkerl commented Nov 8, 2024

The manual run of r-valgrind CI ran successfully to completion:
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11745362897/job/32722604067

@johnkerl johnkerl merged commit 99fbad0 into main Nov 8, 2024
2 of 3 checks passed
@johnkerl johnkerl deleted the kerl/r-valgrind-ci-fix branch November 8, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants