[python] Consolidate all _set_coords
methods into single _util
function
#3292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
As part of work for #3053.
Changes:
This is clean-up work.
This takes the separate implementations of
_set_coords
from_dataframe
,_sparse_nd_array
,_spatial_dataframe
, and_soma_array
into a single_util._set_coords
._cast_domainish
was also moved out ofSOMAArrayWrapper
and into_util
to support casting of domains and NEDs in_set_coord
.Note for reviewers:
I am unsure if
_util.py
is the appropriate place for this.