-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Apply subarrays for dense reads and writes #3263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
[c++] Apply subarrays for dense reads and writes
[c++] Apply subarrays for dense reads and writes [WIP]
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
+ Coverage 83.79% 83.81% +0.01%
==========================================
Files 51 51
Lines 5567 5578 +11
==========================================
+ Hits 4665 4675 +10
- Misses 902 903 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Oct 30, 2024
johnkerl
force-pushed
the
kerl/dense-range-trim
branch
2 times, most recently
from
October 30, 2024 22:29
8049de7
to
c2e9a8c
Compare
johnkerl
force-pushed
the
kerl/dense-range-trim
branch
from
October 31, 2024 16:15
c2e9a8c
to
fc3b726
Compare
johnkerl
force-pushed
the
kerl/dense-range-trim
branch
from
October 31, 2024 16:18
fc3b726
to
631ff1b
Compare
johnkerl
changed the title
[c++] Apply subarrays for dense reads and writes [WIP]
[c++] Apply subarrays for dense reads and writes
Oct 31, 2024
@nguyenv ready for review 🙏 |
johnkerl
force-pushed
the
kerl/dense-range-trim
branch
from
October 31, 2024 20:06
febaa7a
to
14acca3
Compare
This was referenced Oct 31, 2024
nguyenv
approved these changes
Oct 31, 2024
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Thanks @nguyenv !!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
As found on #3244:
dev
#3244 is:libtiledbsoma
, inManagedQuery
, beforesubmit_query
(lo, hi)
Notes for Reviewer: