[c++/python/r] Rename a helper function #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/helper-rename
branch
from
be5fa66 to
4574d28
Compare
XanthosXanthopoulos
approved these changes
Oct 3, 2024
johnkerl
force-pushed
the
kerl/helper-rename
branch
from
4574d28 to
35b0569
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3127 +/- ##
==========================================
+ Coverage 82.49% 82.60% +0.11%
==========================================
Files 50 50
Lines 5204 5204
==========================================
+ Hits 4293 4299 +6
+ Misses 911 905 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: In support of issue #2407 / [sc-51048].
Changes:
This is to help me deconfuse on #2964. The method in question is mainly an internal helper for experiment-level resizing. I want its name to be as clear as possible nonetheless.
Notes for Reviewer: