Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++/python/r] Use libtiledbsoma for R schema evolution #3100

Merged
merged 5 commits into from
Oct 2, 2024
Merged

[c++/python/r] Use libtiledbsoma for R schema evolution #3100

merged 5 commits into from
Oct 2, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 1, 2024 •
edited
Loading

Issue and/or context: This is an item on #2406: in particular #3057 / [sc-55679]/

Changes:

  • Move the pybind11 update_dataframe entirely to libtiledbsoma (it's ready to go, no mods needed)
  • Call that from R, removing another TileDB-R callsite

Notes for Reviewer:

See also #3115.

@johnkerl johnkerl force-pushed the kerl/r-schevo-pushdown branch from cae57ca to c84c8c1 Compare October 1, 2024 03:53
@johnkerl johnkerl mentioned this pull request Oct 1, 2024
Merged
@johnkerl johnkerl force-pushed the kerl/r-schevo-pushdown branch 3 times, most recently from 262b8e4 to 6666d58 Compare October 2, 2024 13:30
@johnkerl johnkerl changed the base branch from main to kerl/cpp-update-dataframe-pushdown October 2, 2024 13:31
@johnkerl johnkerl force-pushed the kerl/r-schevo-pushdown branch from 6666d58 to 751e3b7 Compare October 2, 2024 16:36
Base automatically changed from kerl/cpp-update-dataframe-pushdown to main October 2, 2024 17:12
@johnkerl johnkerl force-pushed the kerl/r-schevo-pushdown branch from 751e3b7 to df8240a Compare October 2, 2024 17:23
@johnkerl johnkerl requested a review from mojaveazure October 2, 2024 17:23
@johnkerl johnkerl marked this pull request as ready for review October 2, 2024 17:23
@johnkerl johnkerl mentioned this pull request Oct 2, 2024
Open
mojaveazure
mojaveazure approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions where we can be a bit more performant; I'd strongly recommend using them, but if you don't want then ignore and 🚢

apis/r/R/SOMADataFrame.R Outdated Show resolved Hide resolved
apis/r/R/SOMADataFrame.R Outdated Show resolved Hide resolved
@johnkerl johnkerl force-pushed the kerl/r-schevo-pushdown branch from 92bd791 to 928c272 Compare October 2, 2024 18:03
@johnkerl johnkerl merged commit 6541cfe into main Oct 2, 2024
4 checks passed
@johnkerl johnkerl deleted the kerl/r-schevo-pushdown branch October 2, 2024 18:52
@johnkerl johnkerl mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojaveazure mojaveazure mojaveazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkerl @mojaveazure