Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Run clang-format on apis/r/src (except autogen code) #3048

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 23, 2024

While working on #2407 / [sc-51048] and #2406.

This was fully automated via

 clang-format -i  apis/r/src/[a-z]*.cpp

with the exception of a couple fix-ups on //'-style comments.

Note that we enitrely avoid apis/r/src/RcppExports.cpp which is auto-generated.

On this PR I just manually ran the formatter on the relevant source files. On a follow-up PR I'll stop excluding these files from the format-checker which we run on the rest of our libtiledbsoma and pybind11 C++ source:
https://github.com/single-cell-data/TileDB-SOMA/blob/1.14.1/.github/workflows/python-ci-single.yml#L62-L64

Also note that we should move the clang-format checker from python-ci-single.yml to another C++-specific YAML file.

@johnkerl johnkerl requested review from mojaveazure, nguyenv and jp-dark and removed request for nguyenv, mojaveazure and jp-dark September 23, 2024 22:51
@johnkerl johnkerl marked this pull request as draft September 23, 2024 23:02
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (fd1537f) to head (0fd2de9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3048   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          41       41           
  Lines        4113     4113           
=======================================
  Hits         3690     3690           
  Misses        423      423           
Flag Coverage Δ
python 89.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.71% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl marked this pull request as ready for review September 24, 2024 15:44
@johnkerl johnkerl requested a review from jp-dark September 25, 2024 14:05
@johnkerl johnkerl merged commit a5961fa into main Sep 25, 2024
4 checks passed
@johnkerl johnkerl deleted the kerl/r-clang-format branch September 25, 2024 14:56
@johnkerl johnkerl changed the title [r] Run clang-format on apis/r/src [r] Run clang-format on apis/r/src (except autogen code) Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants