-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Resize for variant-indexed DataFrame
#2917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 89.87% 90.02% +0.15%
==========================================
Files 38 38
Lines 3999 3999
==========================================
+ Hits 3594 3600 +6
+ Misses 405 399 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 19, 2024 02:48
6db6134
to
21155f6
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
August 19, 2024 02:59
b915255
to
e7e8cc2
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 19, 2024 03:05
21155f6
to
696ab50
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
August 19, 2024 03:11
5d38f9f
to
8a949db
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 19, 2024 04:02
8a949db
to
361e2bc
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
2 times, most recently
from
August 20, 2024 19:55
0cd5ce5
to
0831bdb
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 20, 2024 19:57
361e2bc
to
3a93b65
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 20, 2024 20:00
0831bdb
to
8c5b2af
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
2 times, most recently
from
August 20, 2024 20:07
10d1add
to
976c398
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 28, 2024 13:48
b56d07a
to
651ee8a
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 28, 2024 13:49
976c398
to
86f1ce3
Compare
This was referenced Aug 28, 2024
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 29, 2024 19:55
651ee8a
to
c875bff
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 29, 2024 19:59
86f1ce3
to
fa120ef
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 30, 2024 21:17
c875bff
to
68d9d3e
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 30, 2024 21:18
fa120ef
to
1bf7b10
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
3 times, most recently
from
August 30, 2024 21:55
982b541
to
2f01e04
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 30, 2024 22:02
1bf7b10
to
cfcc1e0
Compare
johnkerl
force-pushed
the
kerl/sdf-shape
branch
from
August 30, 2024 22:07
2f01e04
to
63efc44
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
4 times, most recently
from
August 31, 2024 17:02
ba690fb
to
0ffd904
Compare
johnkerl
changed the title
[c++] Resize for variant-indexed
[c++] Resize for variant-indexed Aug 31, 2024
DataFrame
[WIP]DataFrame
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
3 times, most recently
from
August 31, 2024 23:06
046fdbf
to
d27a748
Compare
johnkerl
force-pushed
the
kerl/cpp-resizes
branch
from
August 31, 2024 23:13
d27a748
to
f55fd5e
Compare
nguyenv
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This follows on #2917 for issue #2407 / [sc-51048]. Here we implement
resize
.Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
While
SOMASparseNDArray
andSOMADenseNDArray
must always and only haveint64
dims within the SOMA data model,SOMADataFrame
is different. The default behavior -- which almost everyone uses -- has a singlesoma_joinid
dim which is indeed of typeint64
. (Also note thatexp.obs.shape
does exist within TileDB-SOMA-Py, and people do call it.) However, the spec only requires thatsoma_joinid
exist as a dim or an attr: it can be a dim along with others, or it can not be a dim at all. Here we do the right thing, without and with current-domain support, to allow people to resize thesoma_joinid
dim, and only that, whether it's the sole dimension, a dimension but not the sole one, or not a dim at all.Notes for Reviewer: