Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Trivial parameterizes in test/common.cc #2910

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Aug 17, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Changes:

Up until now the number of rows in arrow-schema/arrow-data for dataframe setup from Python/R to C++ has had 3 slots. On #2785 it will necessarily have 5. This PR parameterizes some hard-coded values of 3 to now reference n, after int n = 3.

Similarly, this PR replaces a hard-coded within-function 1000 to a new parameter dim_max for use by callers, who will need explicit construction access to test resize logic for upcoming PRs on #2407.

Notes for Reviewer:

@johnkerl johnkerl requested review from nguyenv and jp-dark August 17, 2024 15:08
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (bdba3c3) to head (d93cdf8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
+ Coverage   89.88%   90.03%   +0.15%     
==========================================
  Files          37       37              
  Lines        3925     3925              
==========================================
+ Hits         3528     3534       +6     
+ Misses        397      391       -6     
Flag Coverage Δ
python 90.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.03% <ø> (+0.15%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [c++] Trivial parameterize in test/common.cc [c++] Trivial parameterizes in test/common.cc Aug 17, 2024
@johnkerl johnkerl merged commit f95f21f into main Aug 19, 2024
14 of 15 checks passed
@johnkerl johnkerl deleted the kerl/test-common-parameterize branch August 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants