Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TileDB Core 2.20, TileDB-Py 0.26, TileDB-R 0.24 #2150

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

johnkerl
Copy link
Member

[sc-41030]

Copy link

This pull request has been linked to Shortcut Story #41030: Update projects to TileDB 2.20.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #2150 (2b93c63) into main (3f64022) will decrease coverage by 13.69%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2150       +/-   ##
===========================================
- Coverage   81.15%   67.46%   -13.69%     
===========================================
  Files          84       50       -34     
  Lines        6341     2536     -3805     
  Branches      215      215               
===========================================
- Hits         5146     1711     -3435     
+ Misses       1096      726      -370     
  Partials       99       99               
Flag Coverage Δ
libtiledbsoma 67.46% <ø> (-0.16%) ⬇️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.75% <ø> (ø)

@eddelbuettel
Copy link
Contributor

eddelbuettel commented Feb 15, 2024

This may have to be on hold for the R side of things until 0.24.0 is actually i) at CRAN, ii) merged into main, iii) tagged as a release, iv) built everywhere we care about (r2u, conda, ...)

We are waiting for a human override at CRAN as the package is held for an issue outside the package, and our control.

@johnkerl
Copy link
Member Author

johnkerl commented Feb 15, 2024

All good @eddelbuettel -- and thank you -- this PR is "up and ready to poke the retry button" whenever (and by whomever, although realistically I'll mostly likely be the one pushing the retry button when that's ready)

@johnkerl johnkerl marked this pull request as draft February 15, 2024 14:43
@johnkerl johnkerl changed the title Use TileDB Core 2.20, TileDB-Py 0.26, TileDB-R 0.24 Use TileDB Core 2.20, TileDB-Py 0.26, TileDB-R 0.24 [WIP] Feb 15, 2024
@johnkerl johnkerl marked this pull request as ready for review February 20, 2024 22:22
@johnkerl johnkerl changed the title Use TileDB Core 2.20, TileDB-Py 0.26, TileDB-R 0.24 [WIP] Use TileDB Core 2.20, TileDB-Py 0.26, TileDB-R 0.24 Feb 20, 2024
@eddelbuettel
Copy link
Contributor

As just commented in another issue, it is a little different 'this time' and at least now as we have a release, binaries where we make them ... but no CRAN release (yet at least).

@johnkerl
Copy link
Member Author

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7981175554/job/21792363225?pr=2150 shows that we are getting core 2.20.1 for TileDB-SOMA-R but 2.20.0 via TileDB-Py 0.26.0:

Run Rscript -e 'tiledbsoma::show_package_versions()'
tiledbsoma:    1.7.99.3
tiledb-r:      0.2[4](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7981175554/job/21792363225?pr=2150#step:11:5).0.1
tiledb core:   2.20.1
libtiledbsoma: 2.20.1
R:             R version 4.3.2 (2023-10-31)
OS:            Ubuntu 22.04.3 LTS

Run python -c 'import tiledbsoma; tiledbsoma.show_package_versions()'
tiledbsoma.__version__        1.5.0rc0.post214.dev362487835
TileDB-Py tiledb.version()    (0, 26, 0)
TileDB core version           2.20.0
libtiledbsoma version()       libtiledb=2.20.1
python version                3.10.13.final.0
OS version                    Linux 6.2.0-1019-azure
tiledbsoma.__version__    1.5.0rc0.post214.dev362487835
tiledb.version()          0.26.0
core version              2.20.0
anndata.__version__  (ad) 0.10.5.post1
numpy.__version__    (np) 1.26.4
pandas.__version__   (pd) 2.2.0
pyarrow.__version__  (pa) 15.0.0
scanpy.__version__   (sc) 1.9.8
scipy.__version__    (sp) 1.[12](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7981175554/job/21792363225?pr=2150#step:15:13).0
python__version__         3.10.[13](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7981175554/job/21792363225?pr=2150#step:15:14)

cc @ihnorton

@johnkerl
Copy link
Member Author

Dependencies as discussed in Slack with @ihnorton

@johnkerl johnkerl merged commit a4a4e85 into main Feb 28, 2024
18 checks passed
@johnkerl johnkerl deleted the kerl/2.20 branch February 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants