[python] Use bindings for SparseNDArray readpath
#2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2133 +/- ##
==========================================
- Coverage 78.65% 72.05% -6.60%
==========================================
Files 136 102 -34
Lines 10666 6881 -3785
Branches 215 215
==========================================
- Hits 8389 4958 -3431
+ Misses 2178 1824 -354
Partials 99 99
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Needs to be updated to use |
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-dense-ndarray
branch
from
229e297 to
a185f8a
Compare
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-sparse-ndarray
branch
2 times, most recently
from
06bcbe9 to
e60bb37
Compare
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-dense-ndarray
branch
from
d0a2f6c to
7185a5e
Compare
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-sparse-ndarray
branch
3 times, most recently
from
c1a78b0 to
7a0c6b2
Compare
Base automatically changed from
viviannguyen/use-bindings-for-dense-ndarray
to
main
February 24, 2024 12:57
nguyenv
force-pushed
the
viviannguyen/use-bindings-for-sparse-ndarray
branch
from
7a0c6b2 to
41efdf7
Compare
|
This is ready for review. |
thetorpedodog
approved these changes
Feb 26, 2024
|
[sc-40220] |
|
This pull request has been linked to Shortcut Story #40220: [python] Use SOMASparseNDArray bindings in class SparseNDArray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2077
Changes:
Use
clib.SparseNDArrayfor read path, replacing usage oftiledb.Array.These changes were picked out of #1817.
Notes for Reviewer:
These changes are on top of #2132.