-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Refactor SOMAArray
and SOMAGroup
to inherit from SOMAObject
#2124
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2124 +/- ##
==========================================
+ Coverage 78.43% 78.70% +0.27%
==========================================
Files 136 136
Lines 10759 10704 -55
Branches 209 211 +2
==========================================
- Hits 8439 8425 -14
+ Misses 2222 2177 -45
- Partials 98 102 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6e37282
to
428fab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One possible small enhancement but should work either way.
Co-authored-by: Dirk Eddelbuettel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Issue and/or context:
#2123
Changes:
SOMAArray
andSOMAGroup
to inherit fromSOMAObject
-mmacosx-version-min=11.0
to support usage of C++17 featurestd::filesystem::path
These changes were picked out of #1817. I am opening smaller PRs to make it easier to review this time.