Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support group member deletion #210

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Support group member deletion #210

merged 3 commits into from
Jul 1, 2022

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jul 1, 2022

@johnkerl johnkerl requested review from aaronwolen and gsakkis July 1, 2022 19:06
@johnkerl johnkerl merged commit 215c0e0 into main Jul 1, 2022
@johnkerl johnkerl deleted the kerl/remove branch July 1, 2022 20:50
@gsakkis
Copy link
Contributor

gsakkis commented Jul 3, 2022

Although there is a __delete__ magic method for descriptors, that's probably not what you mean here. Since there are no tests for the intended usage as there are for remove, I guess the intention is to override __delitem__ (and perhaps __delattr__ as well since you have overriden __getattr__ to be essentially an alias to __getitem__).

@johnkerl
Copy link
Member Author

johnkerl commented Jul 5, 2022 •
edited
Loading

@gsakkis thanks for your kind and expert advice! I'll take a careful look at all these.

@johnkerl johnkerl mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronwolen aaronwolen aaronwolen approved these changes

@gsakkis gsakkis Awaiting requested review from gsakkis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnkerl @gsakkis @aaronwolen