Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Update README.md installation instructions in preparation for 1.0[rc] #1502

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

mlin
Copy link
Member

@mlin mlin commented Jun 23, 2023

Note: the chanzuckerberg R-universe serves tiledbsoma but not TileDB-R. Users following the instructions in a fresh environment will get the GitHub-Released version of tiledbsoma, and the CRAN version of tiledb. Consequently, to release tiledbsoma we must ensure any necessary changes to TileDB-R have made it out to CRAN. (We do plan to publish tiledbsoma on CRAN once ready, so this just pulls that constraint forward a bit.)

@mlin mlin added documentation Improvements or additions to documentation r-api 1.0rc-r labels Jun 23, 2023
@mlin mlin requested review from eddelbuettel and johnkerl June 23, 2023 02:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -11.67 ⚠️

Comparison is base (bde7c23) 64.67% compared to head (a6c7147) 53.01%.

❗ Current head a6c7147 differs from pull request most recent head 298d27a. Consider uploading reports for the commit 298d27a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1502       +/-   ##
===========================================
- Coverage   64.67%   53.01%   -11.67%     
===========================================
  Files         102       72       -30     
  Lines        8346     5825     -2521     
===========================================
- Hits         5398     3088     -2310     
+ Misses       2948     2737      -211     
Flag Coverage Δ
python ?
r 53.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eddelbuettel
Copy link
Contributor

Note: the chanzuckerberg R-universe serves tiledbsoma but not TileDB-R.

You could add this. That is no differet from us one adding tiledb-some so that census loads -- that took us from one entry cellxgene.census in your packages.json to two by adding tiledbsoma; now we'd add tiledb-r. That said of course we can also edit the packages.json for tiledb (PR welcome).

apis/r/README.md Outdated
@@ -22,6 +22,12 @@ mamba install -c conda-forge -c tiledb r-tiledbsoma

## From source

To install the very latest tiledbsoma development version (our `main` branch), use [`devtools::install_github()`](https://cran.r-project.org/web/packages/githubinstall/vignettes/githubinstall.html):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devtools is midly deprecated (and pulls in too much other stuff), suggest to use remotes::install_github() which is a little narrower.

apis/r/README.md Outdated

```r
install.packages('tiledbsoma', repos = c('https://tiledb-inc.r-universe.dev',
install.packages('tiledbsoma', repos = c('https://chanzuckerberg.r-universe.dev',
'https://cloud.r-project.org'))
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense to mention that r-universe has macOS binaries (as well as Ubuntu jammy for R 4.3.1). It would have windows binaries if we built for Windows.

Conda/mamba exists to and for multiple architectures but users who are "mostly R users" (and are not also Python users in corporate settings) generally do not do conda.

apis/r/README.md Outdated
To install the very latest tiledbsoma development version (our `main` branch), use [`devtools::install_github()`](https://cran.r-project.org/web/packages/githubinstall/vignettes/githubinstall.html):

```r
devtools::install_github("https://github.com/single-cell-data/TileDB-SOMA", subdir="apis/r")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remotes::install_github()

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, but I added a few comments you may want to look at, but of course feel free to disregard them as you see fit.

@Shelnutt2 Shelnutt2 requested a review from aaronwolen June 23, 2023 03:37
@mlin mlin marked this pull request as draft June 23, 2023 03:44
@mlin mlin marked this pull request as ready for review June 28, 2023 22:20
apis/r/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0rc-r documentation Improvements or additions to documentation r-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants