-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Use artifacts if no args or system libs found #1454
Conversation
This pull request has been linked to Shortcut Story #29983: [r] Use artifacts, or user arguments for local library, or system library. |
a41088d
to
4aba5f3
Compare
4aba5f3
to
da7515b
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
===========================================
+ Coverage 63.92% 91.63% +27.70%
===========================================
Files 99 30 -69
Lines 8220 2521 -5699
===========================================
- Hits 5255 2310 -2945
+ Misses 2965 211 -2754
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
70c9634
to
d1d45c5
Compare
This PR is making good progress. We now have
What is still missing is a consistent propagation of version numbers from the top level to the different packages. |
Note: This requires #1397 as a prerequisite.
Issue and/or context:
The R package build has, besides the usual R package dependencies, a dual dependency on TileDB Core and the TileDB-SOMA C++ library. This PR generalizes the build to access
pkg-config
is present and knows about the librariesChanges:
This PR generalizes the build a to allow for the optional use, the use of partial optional use along with
pkg-config
, full use ofpkg-config
for both as before as well as an extended use of now two binary artifacts. The artifact case has been tested on Docker when no libraries were present.Notes for Reviewer:
This PR depends on #1397 to produce the artifacts first. It also still requires a manual updating of which artifacts are downloaded, the pinning is currently hard.