Python-side code-review feedback

apis/python/src/tiledbsoma/_dataframe.py

@@ -298,13 +298,15 @@ def create(
             )
 
             if index_column_name == "soma_joinid":
-                if slot_core_current_domain[0] != 0:
+                lower = slot_core_current_domain[0]
+                upper = slot_core_current_domain[1]
+                if lower != 0:
                     raise ValueError(
-                        f"domain for soma_joinid must have lower bound of 0; got {slot_core_current_domain[0]}"
+                        f"domain for soma_joinid must have lower bound of 0; got {lower}"
                     )
-                if slot_core_max_domain[0] != 0:
+                if upper < 0:
                     raise ValueError(
-                        f"maxdomain for soma_joinid must have lower bound of 0; got {slot_core_max_domain[0]}"
+                        f"domain for soma_joinid must have upper bound >= 0; got {upper}"
                     )
 
             # Here is our Arrow data API for communicating schema info between

apis/python/tests/test_dataframe.py

@@ -1871,7 +1871,7 @@ def test_presence_matrix(tmp_path):
     assert actual.equals(df)
 
 
-def test_lower_bound_on_somajoinid_domain(tmp_path):
+def test_bounds_on_somajoinid_domain(tmp_path):
     uri = tmp_path.as_posix()
 
     schema = pa.schema(
@@ -1890,6 +1890,13 @@ def test_lower_bound_on_somajoinid_domain(tmp_path):
             domain=[[2, 99]],
         )
 
+    with pytest.raises(ValueError):
+        soma.DataFrame.create(
+            uri,
+            schema=schema,
+            domain=[[0, -1]],
+        )
+
     soma.DataFrame.create(
         uri,
         schema=schema,