code-review feedback

Co-authored-by: nguyenv <[email protected]>
single-cell-data · Sep 20, 2024 · 7dd8412 · 7dd8412
1 parent 804db2b
commit 7dd8412
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/libtiledbsoma/src/soma/soma_array.cc b/libtiledbsoma/src/soma/soma_array.cc
@@ -1224,14 +1224,10 @@ ArrowTable SOMAArray::_get_core_domainish(enum Domainish which_kind) {
                 break;
 
             default:
-                break;
-        }
-
-        if (child == nullptr) {
-            throw TileDBSOMAError(fmt::format(
-                "SOMAArray::_get_core_domainish:dim {} has unhandled type {}",
-                core_dim.name(),
-                tiledb::impl::type_to_str(core_type_code)));
+                throw TileDBSOMAError(fmt::format(
+                    "SOMAArray::_get_core_domainish:dim {} has unhandled type {}",
+                     core_dim.name(),
+                     tiledb::impl::type_to_str(core_type_code)));
         }
         arrow_array->children[i] = child;
     }