code-review feedback [skip ci]

Co-authored-by: Julia Dark <[email protected]>
single-cell-data · Nov 13, 2024 · 3482173 · 3482173
1 parent 37cf641
commit 3482173
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apis/r/src/rinterface.cpp b/apis/r/src/rinterface.cpp
@@ -404,7 +404,7 @@ SEXP c_schema(const std::string& uri, Rcpp::XPtr<somactx_wrap_t> ctxxp) {
         ArrowSchemaAllocateChildren(sch, lib_retval->n_children),
         "Bad schema children alloc");
 
-    for (size_t i = 0; i < (size_t)lib_retval->n_children; i++) {
+    for (size_t i = 0; i < static_cast<size_t>(lib_retval->n_children); i++) {
         spdl::info(
             "[c_schema] Accessing name '{}' format '{}' at position {}",
             std::string(lib_retval->children[i]->name),

diff --git a/apis/r/src/rutilities.cpp b/apis/r/src/rutilities.cpp
@@ -468,7 +468,7 @@ SEXP convert_domainish(const tdbs::ArrowTable& arrow_table) {
         ArrowArrayAllocateChildren(arr, arrow_array->n_children),
         "Bad array children alloc");
 
-    for (size_t i = 0; i < (size_t)ncol; i++) {
+    for (size_t i = 0; i < static_cast<size_t>(ncol); i++) {
         if (arrow_array->children[i]->n_buffers == 3) {
             // Arrow semantics: variable-length: buffers 0,1,2 are validity,
             // offsets, data