Split {test_,}pytorch.py into a few files
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
force-pushed
the
rw/files
branch
from
c29ad6f to
0708496
Compare
bkmartinjr
reviewed
Dec 17, 2024
| ) | ||
| from .dataloader import experiment_dataloader | ||
| from .datapipe import ExperimentAxisQueryIterDataPipe | ||
| from .dataset import ExperimentAxisQueryIterableDataset |
There was a problem hiding this comment.
do you need to define __all__?
There was a problem hiding this comment.
It's down at L14, unchanged
bkmartinjr
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored some classes/functions from
pytorch.pyinto their own files:dataset.py: ExperimentAxisQueryIterableDatasetdatapipe.py: ExperimentAxisQueryIterDataPipedataloader.py:experiment_dataloaderwrapper_csr.py:CSR_IO_Buffer_distributed.py: multiprocess world/rank helpers_experiment_locator.py: ExperimentLocator_utils:splits,batchedThe code is unchanged
Some
test_pytorch.pytests are similarly moved to files named after the above new files. Pytest@fixtures are also moved toconftest.py(for reuse across test files), andtests/_utils.pycontains generic test helper functions.b03c65f renamed these type aliases:
Also a couple nits in 16a6090