Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tutorial notebooks (PR 7 of N) #10

Merged
merged 6 commits into from
Oct 15, 2024
Merged

add tutorial notebooks (PR 7 of N) #10

merged 6 commits into from
Oct 15, 2024

Conversation

bkmartinjr
Copy link
Member

Add three notebooks (some are partial - functional but need additional verbiage before release).

  • tutorial_pytorch: demonstrate toy model using a DataPipe
  • tutorial_lightning: demonstrate toy model using Lighnting
  • tutorial_multiworker: demo sharp edges with distributed/multi-worker usage (e.g., set_epoch)

@bkmartinjr bkmartinjr mentioned this pull request Sep 24, 2024
Closed
@ryan-williams ryan-williams force-pushed the bkmartinjr/add-shuffling branch from 33f2c06 to ccf373d Compare September 25, 2024 16:35
@ryan-williams ryan-williams force-pushed the bkmartinjr/add-notebooks branch 2 times, most recently from 9334e02 to a8c16c6 Compare September 25, 2024 16:40
aaronwolen
aaronwolen approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks are really helpful and ran perfectly for me. I made a few minor comments/suggestions.

notebooks/tutorial_pytorch.ipynb Outdated Show resolved Hide resolved
notebooks/tutorial_pytorch.ipynb Show resolved Hide resolved
notebooks/tutorial_pytorch.ipynb Outdated Show resolved Hide resolved
notebooks/tutorial_pytorch.ipynb Outdated Show resolved Hide resolved
notebooks/tutorial_lightning.ipynb Outdated Show resolved Hide resolved
notebooks/tutorial_multiworker.ipynb Outdated Show resolved Hide resolved
@ryan-williams ryan-williams force-pushed the bkmartinjr/add-shuffling branch from ccf373d to 1cc3670 Compare October 3, 2024 21:40
@ryan-williams ryan-williams force-pushed the bkmartinjr/add-notebooks branch from ee453d4 to 74b77eb Compare October 3, 2024 21:40
Base automatically changed from bkmartinjr/add-shuffling to main October 15, 2024 01:28
@bkmartinjr bkmartinjr merged commit fdfed24 into main Oct 15, 2024
24 checks passed
@bkmartinjr bkmartinjr deleted the bkmartinjr/add-notebooks branch October 15, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronwolen aaronwolen aaronwolen approved these changes

@ryan-williams ryan-williams Awaiting requested review from ryan-williams

@johnkerl johnkerl Awaiting requested review from johnkerl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkmartinjr @ryan-williams @aaronwolen