Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the stripe api timeout #61

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Remove the stripe api timeout #61

merged 2 commits into from
Apr 14, 2020

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Apr 13, 2020

Description of change

Remove the timout of 15s on the stripe client.

https://stitchdata.atlassian.net/browse/SUP-1411

Manual QA steps

  • Test pass

Risks

  • Low - There appears to be some historical context around why we set a timeout, but tap-tester passes and nothing jumps out to me as a reason to not allow the default timeout.

Rollback steps

  • revert this branch

dmosorast
dmosorast approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment there so we remember we can increase it? Not sure if that'd be helpful or clutterful.

Looks good though, this should help.

@cosimon cosimon merged commit 6c92af3 into master Apr 14, 2020
@cosimon cosimon deleted the fix/remove-timeout branch April 14, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosimon @dmosorast