Move the "card" schema entry under "payment_method_details" #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat's where stripe puts it.
luandy64
reviewed
Jan 10, 2020
KAllan357
approved these changes
Jan 13, 2020
luandy64
reviewed
Jan 13, 2020
.circleci/config.yml
Outdated
| name: 'JSON Validator' | ||
| command: | | ||
| source /usr/local/share/virtualenvs/tap-tester/bin/activate | ||
| stitch-validate-json ~/.virtualenvs/tap-stripe/lib/python3.5/site-packages/tap_stripe/schemas/*.json |
There was a problem hiding this comment.
I think this path is wrong. Did you run this locally?
There was a problem hiding this comment.
Ignore me. Github plopped me in a one commit window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
https://stitchdata.atlassian.net/browse/SUP-1119
The card details are returned by the Stripe API under "payment_method_details". Have the schema match this.
Manual QA steps
Risks
Rollback steps