Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 min lookback for immutable streams to prevent missing records #45

Merged
merged 3 commits into from
Dec 6, 2019
Merged

Add 5 min lookback for immutable streams to prevent missing records #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a7c378
Add 5 min lookback for immutable streams to prevent missing records
dmosorast Dec 6, 2019
50ae48a
Pull magic number into a constant
dmosorast Dec 6, 2019
e2ac1a7
Disable TODO warning in pylint
dmosorast Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tap_stripe/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@
'payouts': 'payout_transactions'
}

# NB: These streams will only sync through once for creates, never updates.
IMMUTABLE_STREAMS = {'balance_transactions', 'events'}
IMMUTABLE_STREAM_LOOKBACK = 300 # 5 min in epoch time, Stripe accuracy is to the second

LOGGER = singer.get_logger()

DEFAULT_DATE_WINDOW_SIZE = 30 #days
Expand Down Expand Up @@ -429,6 +433,17 @@ def sync_stream(stream_name):
LOGGER.info('Using non-default date window size of %d', window_size)
start_window = bookmark

# NB: Immutable streams are never synced for updates. We've
# observed a short lag period between when records are created and
# when they are available via the API, so these streams will need
# a short lookback window.
if stream_name in IMMUTABLE_STREAMS:
# pylint:disable=fixme
# TODO: This may be an issue for other streams' created_at
# entries, but to keep the surface small, doing this only for
# immutable streams at first to confirm the suspicion.
start_window -= IMMUTABLE_STREAM_LOOKBACK

# NB: We observed records coming through newest->oldest and so
# date-windowing was added and the tap only bookmarks after it has
# gotten through a date window
Expand Down