Add subsciption and subscription_item to line_item PK #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosorast
added a commit
that referenced
this pull request
Jun 13, 2019
This reverts commit 0d16f4e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been the case with the moving target of a unique identifier that describes a
line_itemon an invoice, it appears there are cases where two line items can share the sameid,invoice, andsubscription, but differ in theirsubscription_itemvalue.Rather than trying to construct an artificial unique primary key, this PR adds to the scope of what identifies a unique record by including
subscriptionandsubscription_item, if present. If these are not present, then it is assumed that the other keys define it as a unique record, and the missing properties are added to the record asnullto pass validation.