TDL-14058: Update SDK and api version #105

savan-chovatiya · 2021-12-20T06:45:57Z

Description of change

TDL-14058: Update SDK API Versions

Updated API and SDK versions and also made some required changes mentioned in the stability analysis except schema quality.
https://docs.google.com/presentation/d/1HVkKmBhPuvwD854ZeMwplRNyk8oVtFEpIuFKNERL5tQ

Manual QA steps

Risks

Rollback steps

revert this branch

…invoices

… update-sdk-and-api-version

prijendev · 2022-01-03T06:10:54Z

tests/test_all_fields.py

    'subscriptions':{
        'payment_settings',
        'default_tax_rates',
        'pending_update',
        'automatic_tax',
    },
    'products':{
-        'skus',


The response of the latest API(2020-08-27) version does not return skus field.

prijendev · 2022-01-03T06:21:31Z

tests/test_all_fields.py

@@ -55,12 +48,34 @@
    'plans': set(),
    'invoice_line_items': {
        'tax_rates',
-        'unique_id',


The response of the latest API(2020-08-27) version does not return the unique_id field. Also, the updated field is not available in the stripe document. So, removed it from the KNOWN_MISSING_FIELDS map.

namrata270998 · 2022-01-03T09:37:03Z

tests/test_all_fields.py

-        'reversals',
-        'reversed',
-    },
+    'payouts':set(),


As per the API doc, the newest API version that is 2020-08-27, doesn't return these missing fields for the payouts object, hence removing the fields from the dictionary

prijendev · 2022-01-03T10:37:23Z

tests/utils.py

@@ -224,10 +225,10 @@ def list_all_object(stream, max_limit: int = 100, get_invoice_lines: bool = Fals
            if dict_obj.get('data'):
                for obj in dict_obj['data']:

-                    if obj['sources']:
+                    if obj.get('sources'):


obj['sources'] was throwing KeyError in the latest API version.

prijendev · 2022-01-19T05:36:59Z

tests/test_all_fields.py

@@ -145,9 +225,7 @@
    'invoices': {'updated'},
    'plans': {'updated'},
    'invoice_line_items': {
-        'updated',


the updated and subscription_item field is not added by tap. So, removed it from the FIELDS_ADDED_BY_TAP map.

I believe this is a necessary field to get updates. Has the sync strategy for getting updates for a child stream changed?

No, the sync strategy is not changed. But, I verified that the above fields are not available in the records by running sync mode for the invoice_line_items stream. Tap is not adding the above fields in the records of the invoice_line_items stream. Sync for the child stream works based on parent records and parent records would have an updated field. That's why the above fields are removed from the FIELDS_ADDED_BY_TAP map.

KrisPersonal · 2022-01-19T17:36:52Z

tap_stripe/__init__.py

@@ -371,10 +382,13 @@ def reduce_foreign_keys(rec, stream_name):
    return rec


-def paginate(sdk_obj, filter_key, start_date, end_date, limit=100):
+def paginate(sdk_obj, filter_key, start_date, end_date, stream_name, limit=100):


Explain why you have to include the stream_name as a new parameter?

The expand parameter is passed in SDK request in the function and the required values are in the STREAM_TO_EXPAND_FIELDS map. So stream_name is used to retrieve expand's a value from that map.

tap-stripe/tap_stripe/__init__.py

Lines 389 to 391 in 1223197

# Some fields are not available by default with latest API version so

# retrieve it by passing expand paramater in SDK object

expand=STREAM_TO_EXPAND_FIELDS.get(stream_name, []),

KrisPersonal · 2022-01-19T17:39:06Z

tap_stripe/__init__.py

+    # Invoice was bookmarking on `date` but in latest API version, that field is deprecated and replication key changed to `created`
+    # kept `date` in bookmarking as it has to respect bookmark of active connection too
+    if stream_name == 'invoices':
+        stream_bookmark = singer.get_bookmark(Context.state, stream_name, 'date') or \
+            int(utils.strptime_to_utc(Context.config["start_date"]).timestamp())


In the comment it says the bookmark has changed to Created date, whereas in the code you have added start_date? Is start_date similar to created_date? Please explain

The replication key is changed to created but date was used previously so we are trying to get a bookmark from the state using the date key first and if not found in a state then use start_date as a bookmark.

tap-stripe/tap_stripe/__init__.py

Lines 425 to 427 in 1223197

if stream_name == 'invoices':

stream_bookmark = singer.get_bookmark(Context.state, stream_name, 'date') or \

int(utils.strptime_to_utc(Context.config["start_date"]).timestamp())

The previous code was also doing that like looking into state first and not found then use start_date.(Deleted line above)

KrisPersonal · 2022-01-19T17:41:05Z

tap_stripe/__init__.py

+        if sub_stream_name == "invoice_line_items":
+            sub_stream_bookmark = singer.get_bookmark(Context.state, sub_stream_name, 'date') \
+                or int(utils.strptime_to_utc(Context.config["start_date"]).timestamp())
+        else:


In the comment it is mentioned as Created, but in the code it is start_date. Looks the similar code is replicated. Can we write a function which accept these as parameters and set the appropriate bookmark?

Yes, I added get_bookmark_for_stream() function to retrive bookmark and similarly added write_bookmark_for_stream() for writing bookmark.

KrisPersonal · 2022-01-19T17:45:07Z

tests/base.py

+            # Bookmark key changed for `invoices` from `date` to `created` due to latest API change
+            # but for `invoices` stream, the `created` field have integer type(epoch format) from starting so
+            # converting `updated` to epoch for comparison.
+            if stream == "invoices":
+                updated[stream]['messages'] += [m for m in batch['messages']
+                                                    if self.dt_to_ts(m['data'].get("updated")) != m['data'].get(bookmark_key)]
+            else:
+                updated[stream]['messages'] += [m for m in batch['messages']
+                                                    if m['data'].get("updated") != m['data'].get(bookmark_key)]


I'm little bit confused here. In the previous section we are converting updated to integer type to compare with created which made sense. Why are we here doing the comparison with Updated and Updated?

We are doing similar things in the previous section and above section. The only difference is in the previous section we are checking with the == operator to get records that are created. While in the above section we are checking with the != operator to get records that are updated.

kspeer825 · 2022-01-19T14:29:42Z

tests/base.py

+            # Bookmark key changed for `invoices` from `date` to `created` due to latest API change
+            # but for `invoices` stream, the `created` field have integer type(epoch format) from starting so
+            # converting `updated` to epoch for comparison.
+            if stream == "invoices":
+                created[stream]['messages'] += [m for m in batch['messages']
+                                                    if self.dt_to_ts(m['data'].get("updated")) == m['data'].get(bookmark_key)]
+            else:
+                created[stream]['messages'] += [m for m in batch['messages']
+                                                    if m['data'].get("updated") == m['data'].get(bookmark_key)]
+


I don't think this is a best practice for bookmarking. Consistency in the data types for bookmarks is what we want. This may be worth discussing with a dev, if it's unclear.

The bookmark is written in epoch format for all streams like below in STATE.
{"type": "STATE", "value": {"bookmarks": {"charges": {"created": 1642661551}, "charges_events": {"updates_created": 1609459200}, "events": {"created": 1642661567}, "customers": {"created": 1642661570}, "customers_events": {"updates_created": 1609459200}, "plans": {"created": 1642661586}, "plans_events": {"updates_created": 1609459200}, "invoices": {"date": 1642661602}, "invoice_line_items": {"date": 1642661602}, "invoices_events": {"updates_created": 1609459200}, "invoice_items": {"date": 1642661617}, "invoice_items_events": {"updates_created": 1609459200}, "transfers": {"created": 1642661632}, "transfers_events": {"updates_created": 1609459200}, "coupons": {"created": 1642661647}, "coupons_events": {"updates_created": 1609459200}, "subscriptions": {"created": 1642661662}, "subscription_items": {"created": 1642661662}, "subscriptions_events": {"updates_created": 1609459200}, "balance_transactions": {"created": 1642661677}, "payouts": {"created": 1642661680}, "payout_transactions": {"created": 1642661680}, "payouts_events": {"updates_created": 1609459200}, "disputes": {"created": 1642661696}, "disputes_events": {"updates_created": 1609459200}, "products": {"created": 1642661711}, "products_events": {"updates_created": 1609459200}}}}
While the replication key of invoices is emitted in epoch format and date-time for other streams. (In RECORD).

We did not change the data-type to avoid column split because the created field was already there with an integer type. and handled that in a test case.

kspeer825 · 2022-01-19T14:32:41Z

tests/test_all_fields.py

@@ -145,9 +225,7 @@
    'invoices': {'updated'},
    'plans': {'updated'},
    'invoice_line_items': {
-        'updated',


I believe this is a necessary field to get updates. Has the sync strategy for getting updates for a child stream changed?

kspeer825 · 2022-01-19T14:35:07Z

tests/utils.py

                        sources = obj['sources']['data']
                        obj['sources'] = sources
-                    if obj['subscriptions']:
+                    if obj.get('subscriptions'):


* initial commit * added back for all streams * resolved comments * fixed cci errors * fixed typo in comment * updated comment * fixed typo in function * fixed failures * fixed error * resolved failure for discount * updated discount schema * added bugtracker

* Initial commit * Updated util.py �[D�[D�[D�[D�[D�[D�[D�[DAPI version to latest in util.py * Added support of tax_ids field * Updated discount schema * Updated datatype of percent_off field.

* Initial commit * Added back schema_keys * Uncommented expected assertion * Removed skus field from schema

…o pass (#112) * Initial commit * Updated schema file * Removed price field from schema * Removed tax_rates from schema * Removed extra fields from schema * Updated schema file * Added metadata in schema * Added invoice_line_items in KNOWN_FAILING_FIELDS * Updated price value�[D�[D�[D�[D�[Drecord value * Updated all_field test case * Merged changes * Uncommented code * Updated code comment

* initial commit with subscription_items stream * reverted back to all streams * resolved pylint * testing for subscription_items only * resolved error * added back for all streams * resolved cci errors * added commnets * added automatic fields for subscription items * removed updated from the schema * removed empty line and updated base * resolved comments * chahnged updated * reverted changes * reverted changes * removed updated from subscription_items * reverted a type change Co-authored-by: prijendev <[email protected]>

* Initial commit for dict to stripe object conversion * Resolved pylint error * Updated test cases * Added condtion to check dict type

* TDL-14058: Update SDK and api version (#105) * Updated SDK and API version * Added expand parameter for more streams * Updated replication key for invoices * added backward compability for invoice bookmark * Added unit test and code coverage report in circleci * Resolved unit test failure * Updated stripe SDK to latest version * Running all test for testing * updated stripe version in config.yml * Running all test for testing * Running all test for testing * Running all test for testing * Updated base class of tap_tester to handle replication key change of invoices * Reverted back config.yml to run dependant tests * Reverted back config.yml to run dependant tests * Updated all_field test case * Added back payout stream * Added comments in test case * Fixed key in bookmark for invoice_line_items * Fixed key in bookmark for invoice_line_items in get_bookmark * Fixed charge stream for all_field test case * Fixed payouts stream for all_field test case * Updated amount value * Resolved circleci error * Fiexed all_field test case�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[D�[�[�[3~�[�[C�[�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[C�[xed invoice_line_item failure in all_field test case * Fix the build_daily workflow definition * Resolved review comment * Updated all_field test case * Updated test case for customer and invoice_line_item stream * Updated util.py * Removed fields from missing fields * fixed subscription_items stream * Resolved review comment and added function for get and write bookmark * Updated code comment * Tdl 5894 update invoices stream (#115) * initial commit * added back for all streams * resolved comments * fixed cci errors * fixed typo in comment * updated comment * fixed typo in function * fixed failures * fixed error * resolved failure for discount * updated discount schema * added bugtracker * Tdl 6026 Modify 'customer' stream on 'test_all_fields.py' to pass (#109) * Initial commit * Updated util.py �[D�[D�[D�[D�[D�[D�[D�[DAPI version to latest in util.py * Added support of tax_ids field * Updated discount schema * Updated datatype of percent_off field. * Tdl 6597 Modify 'product' stream on 'test_all_fields.py' to pass (#108) * Initial commit * Added back schema_keys * Uncommented expected assertion * Removed skus field from schema * TDL-6587 Modify 'invoice_line_items' stream on 'test_all_fields.py' to pass (#112) * Initial commit * Updated schema file * Removed price field from schema * Removed tax_rates from schema * Removed extra fields from schema * Updated schema file * Added metadata in schema * Added invoice_line_items in KNOWN_FAILING_FIELDS * Updated price value�[D�[D�[D�[D�[Drecord value * Updated all_field test case * Merged changes * Uncommented code * Updated code comment * TDL-5992 modify subscription items stream (#114) * initial commit with subscription_items stream * reverted back to all streams * resolved pylint * testing for subscription_items only * resolved error * added back for all streams * resolved cci errors * added commnets * added automatic fields for subscription items * removed updated from the schema * removed empty line and updated base * resolved comments * chahnged updated * reverted changes * reverted changes * removed updated from subscription_items * reverted a type change Co-authored-by: prijendev <[email protected]> * TDL-17429 Revert back tiers field datatype conversion (#117) * Initial commit for dict to stripe object conversion * Resolved pylint error * Updated test cases * Added condtion to check dict type Co-authored-by: prijendev <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: Prijen Khokhani <[email protected]> * Added tax_type and metadata in subcriptions_items * added the proration_details due to cci failure * TDL-17880 Add missing test cases (#131) * Added event_type field in all schemas * Added test cases for event updates * Updated __init__ file * Updated event_type field to updated_by_event_type field name * Reverted back config.yml file changes * Updated event_type field in all_field test case. * Added missing test case assertion * fixed circleci error and updated tests * updated integration tests to resolve cci failures * removed the unused variables * removed duplicate code * resolved comments * added more comments * added new map for intermittent missing fields * updated schema missing fields map and changed the union * added proper comment Co-authored-by: prijendev <[email protected]> Co-authored-by: nevilparikh_crest <[email protected]> * Tdl 13149 sync payment intent (#127) * Initial commit for payment_intent stream * Updated bookmark test case. * Updated expand parameter for charge stream in utils.py * Updated utils.py * Removed payment_intent object from charge stream * Removed extra field from charges schema * Added card field in schema * Updated transfer_group and application_fee_amount field type * Updated transfer_group field * Updated datatype of destination field * Updated transfer_data * Added payment record creation * Resolved test case error * Resloved all fields test case error * Resolved test case error * Added comments in test case. Co-authored-by: namrata270998 <[email protected]> * Tdl 13711 upgrade json schema (#124) * updated the transform_usage type and integration tests * added plan back to the sub_items * removed the workaround for the invoices 'created' field * updated transform_usage type * added code comment * TDL 15120 add event type field in schemas (#123) * Added event_type field in all schemas * Added test cases for event updates * Updated __init__ file * Updated event_type field to updated_by_event_type field name * Reverted back config.yml file changes * Updated event_type field in all_field test case. Co-authored-by: namrata270998 <[email protected]> * updated charge.json * TDL-14354 log request_id (#135) * logged request_id for the sdk calls * unittests for debug log * changed the logic of new_list and updated unittests * added code comments * rsolved pylint error * resolved cci failures * resolved pylint errors * rsolved pylint * changed the function overwritten for logging request id * resolved PR review comments * skipped schema missing fields to pass the cci * fixed cci issue * added schema missing fields * added receipt_url in fickle fields * resolved PR comments * TDL-17879 added authentication before discovery mode and unittests (#128) * added authentication before discovery mode and unittests * resolved comments * fixed spelling error * added schema missing fields * added comment for pagination test * added detailed comment * added ticket it * fixed circleci errors * Tdl 17878 implement request timeout and retry (#126) * added configurable request timeout with default as 5 minutes * added comments * added schema missing fields missing from schema * fixed cci error * added timeout in readme * TDL-9856: ensure setup includes non-automatic balance transactions (#129) * added test case to verify we sync only automatic payout's transactions * added more comments * resolved PR review comments * resolve CCi error * added doc-string in test_automatic_payout_transactions * resolve CCi error * resolve CCi error * resolve CCi error * resolve CCi error * added try-catch in test_automatic_payout_transactions Co-authored-by: namrata270998 <[email protected]> * TDL-16966: Handle deleted invoice_line_items returned from the events updates endpoint (#137) * Added retry logic for deleted invoice line items * Resolved pylint error * Added backoff over child also * added code to skip deleted invoice line item call * resolved unittest failure * Updated all field test case. * Reverted back changes in base.py * Updated all field test case to pass cci. Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: namrata270998 <[email protected]> * TDL-15168: Use `unique_line_item_id` for invoice updates' lines value instead of `id` (#134) * updated id field for invoice line items * resolve integration test error * updated code to handle null invoice_item for invoice line items * resolve review comments * resolved CCi failure Co-authored-by: namrata270998 <[email protected]> * TDL-9801: `payouts` incorrectly mapped to `transfers` object results in transfer objects replicated by payouts stream (#133) * added payout with transfer for payout events * updated config.yml file * removed unnecessary files * resolved integration test error * resolved integration test error * resolved review comments * fix integration test and run all fields test only * fix cci failure * fix cci failure * fix cci failure * fix cci failure, run all tests Co-authored-by: namrata270998 <[email protected]> * Tdl 17902 fix parent child relationship (#130) * update child bookmark and make child stream independent * fixed pylint * resolved PR review comments * added function comments * added child streams to bookmarks test and added a comment to all_fields * resolved cci error * resolved comments * resolved comments * resolved PR review comments * fixed circleci errors * skipped schema missing fields and removed extra checks for nested fields * skipped receipt_url as it keeps changing every time in all_fields * updated function name in unittest and resolved pylint error (#140) Updated function names of unittest after all PR merge. * TDL-18217 change lookback window logic (#138) * added configurable lookback window * added code comments * resolved comments * resolved comments * changed lookback and added integration test * added new map for intermittently missing fields * resolved events stream lookback issue * updated schema missing fields map * added lookback test in config.yml * initial commit * configurable lookback window for bothstreams with updated tests * resolved cci issue and added new assertion * fixed cci issues * addentsd comme * added lookback test in all_tests_run * changed to same default lookback for both streams * resolved PR review comments * fixed typo error * added code comments * changed the lookback loguc acc to Kyle's suggestions * updated comments * float value in lookback * removed float as giving error * handled 0 scenario for lookback * handled string 0 and fixed cci * resolved comments * skipped new fields not present in schema fields to fix cci * resolved comments * added comments in unittests * added lookback in readme * updated debug with %s instead of f-string * updated unittests for the logger statement * removed the timedelta from start_date in lookback_window test * added all_fields in lookback test deoendency * updated the configurable lookback window test * TDL-19384 optimize logic for parent child relationship to be independent (#141) * initial commit with optimized logic for parent child streams * fixed issues in the invoices and invoice_line_items sync * fixed pylint * updated unittests * TDL-19384: Added Sub Stream check * fixed unittests * resolved PR comments and fix cci issues * updated invoice_line_item to line_item * Updated the code comments * fixed typo * updated code comments and added more unittests * resolved pylint * removed uwanted comments * resolved PR comments * resolved PR comments * resolved PR review comments * added integration test for only parent * resolved PR comments * skipped some newly generated fields from all_fields * added failing field as missing nested field Co-authored-by: dbshah1212 <[email protected]> * removed skipped fields from SCHEMA_MISSING_FIELDS * added missing fields in skipped fields Co-authored-by: savan-chovatiya <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: namrata270998 <[email protected]> Co-authored-by: nevilparikh_crest <[email protected]> Co-authored-by: Harsh <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: dbshah1212 <[email protected]>

savan-chovatiya added 3 commits December 17, 2021 14:37

Updated SDK and API version

bfb9aaf

Added expand parameter for more streams

e943539

Updated replication key for invoices

4f8540e

savan-chovatiya marked this pull request as draft December 20, 2021 06:46

savan-chovatiya and others added 20 commits December 20, 2021 17:05

added backward compability for invoice bookmark

9f7f9bb

Added unit test and code coverage report in circleci

5746fc9

Resolved unit test failure

0f84a64

Updated stripe SDK to latest version

9f56ba2

Running all test for testing

f23a0c3

updated stripe version in config.yml

ab4af98

Running all test for testing

566afcc

Running all test for testing

dc137c7

Running all test for testing

23b02f0

Updated base class of tap_tester to handle replication key change of …

016c0c4

…invoices

Merge branch 'master' of https://github.com/singer-io/tap-stripe into…

cd40d52

… update-sdk-and-api-version

Reverted back config.yml to run dependant tests

a284115

Reverted back config.yml to run dependant tests

e797ca9

Updated all_field test case

d676147

Added back payout stream

f005a9e

Added comments in test case

84b4095

Fixed key in bookmark for invoice_line_items

d111788

Fixed key in bookmark for invoice_line_items in get_bookmark

befe058

Fixed charge stream for all_field test case

98d9d68

Fixed payouts stream for all_field test case

6895c02

prijendev reviewed Jan 3, 2022

View reviewed changes

Updated amount value

6d4dfcc

prijendev reviewed Jan 3, 2022

View reviewed changes

Resolved circleci error

260109b

namrata270998 reviewed Jan 3, 2022

View reviewed changes

prijendev reviewed Jan 3, 2022

View reviewed changes

prijendev added 4 commits January 18, 2022 21:57

Updated all_field test case

6f6cd9f

Updated test case for customer and invoice_line_item stream

098032b

Updated util.py

7419e7a

Removed fields from missing fields

a0a3924

prijendev reviewed Jan 19, 2022

View reviewed changes

fixed subscription_items stream

1223197

dbshah1212 requested review from namrata270998 and prijendev January 19, 2022 06:52

dbshah1212 approved these changes Jan 19, 2022

View reviewed changes

karanpanchal-crest approved these changes Jan 19, 2022

View reviewed changes

savan-chovatiya changed the title ~~Update sdk and api version~~ TDL-14058: Update SDK and api version Jan 19, 2022

savan-chovatiya requested review from kspeer825 and KrisPersonal January 19, 2022 09:15

KrisPersonal reviewed Jan 19, 2022

View reviewed changes

savan-chovatiya added 2 commits January 20, 2022 12:50

Resolved review comment and added function for get and write bookmark

f6b96fc

Updated code comment

44abdf8

savan-chovatiya requested a review from KrisPersonal January 20, 2022 09:19

kspeer825 suggested changes Jan 20, 2022

View reviewed changes

savan-chovatiya requested a review from kspeer825 January 20, 2022 14:03

kspeer825 approved these changes Jan 24, 2022

View reviewed changes

KrisPersonal approved these changes Feb 9, 2022

View reviewed changes

namrata270998 and others added 6 commits February 10, 2022 10:04

Tdl 6026 Modify 'customer' stream on 'test_all_fields.py' to pass (#109)

e2a6fbc

* Initial commit * Updated util.py �[D�[D�[D�[D�[D�[D�[D�[DAPI version to latest in util.py * Added support of tax_ids field * Updated discount schema * Updated datatype of percent_off field.

Tdl 6597 Modify 'product' stream on 'test_all_fields.py' to pass (#108)

f26ab5c

* Initial commit * Added back schema_keys * Uncommented expected assertion * Removed skus field from schema

TDL-17429 Revert back tiers field datatype conversion (#117)

f013574

* Initial commit for dict to stripe object conversion * Resolved pylint error * Updated test cases * Added condtion to check dict type

prijendev merged commit 994fcfd into crest-master Feb 10, 2022

prijendev mentioned this pull request Feb 10, 2022

TDL-10077: Improve Stripe Reliability #118

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TDL-14058: Update SDK and api version #105

TDL-14058: Update SDK and api version #105

savan-chovatiya commented Dec 20, 2021 •

edited

Loading

prijendev Jan 3, 2022

prijendev Jan 3, 2022 •

edited

Loading

namrata270998 Jan 3, 2022 •

edited

Loading

prijendev Jan 3, 2022

prijendev Jan 19, 2022 •

edited

Loading

kspeer825 Jan 19, 2022

prijendev Jan 20, 2022 •

edited

Loading

KrisPersonal Jan 19, 2022

savan-chovatiya Jan 20, 2022

KrisPersonal Jan 19, 2022

savan-chovatiya Jan 20, 2022

KrisPersonal Jan 19, 2022

savan-chovatiya Jan 20, 2022

KrisPersonal Jan 19, 2022

savan-chovatiya Jan 20, 2022

kspeer825 Jan 19, 2022

savan-chovatiya Jan 20, 2022

kspeer825 Jan 19, 2022

kspeer825 Jan 19, 2022

	# Some fields are not available by default with latest API version so
	# retrieve it by passing expand paramater in SDK object
	expand=STREAM_TO_EXPAND_FIELDS.get(stream_name, []),

	if stream_name == 'invoices':
	stream_bookmark = singer.get_bookmark(Context.state, stream_name, 'date') or \
	int(utils.strptime_to_utc(Context.config["start_date"]).timestamp())

TDL-14058: Update SDK and api version #105

TDL-14058: Update SDK and api version #105

Conversation

savan-chovatiya commented Dec 20, 2021 • edited Loading

Description of change

Manual QA steps

Risks

Rollback steps

Choose a reason for hiding this comment

prijendev Jan 3, 2022 • edited Loading

Choose a reason for hiding this comment

namrata270998 Jan 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prijendev Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prijendev Jan 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

savan-chovatiya commented Dec 20, 2021 •

edited

Loading

prijendev Jan 3, 2022 •

edited

Loading

namrata270998 Jan 3, 2022 •

edited

Loading

prijendev Jan 19, 2022 •

edited

Loading

prijendev Jan 20, 2022 •

edited

Loading