Tdl 13587 add inventory item data #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanpanchal-crest
approved these changes
Sep 9, 2021
|
when would the PR's related to inventory items be merged ? is there any ETA ? |
KrisPersonal
requested changes
Sep 29, 2021
tests/test_pagination.py
Outdated
| with self.subTest(store="store_1"): | ||
| conn_id = self.create_connection(original_credentials=True) | ||
| self.pagination_test(conn_id, self.store_1_streams) | ||
| self.pagination_test(conn_id, self.store_1_streams-excepted_streams) |
There was a problem hiding this comment.
Have spaces between store_1_streams and - and expected_streams
Suggested change
| self.pagination_test(conn_id, self.store_1_streams-excepted_streams) | |
| self.pagination_test(conn_id, self.store_1_streams - excepted_streams) |
tests/test_pagination.py
Outdated
|
|
||
| with self.subTest(store="store_2"): | ||
| conn_id = self.create_connection(original_properties=False, original_credentials=False) | ||
| self.pagination_test(conn_id, self.store_2_streams) | ||
| self.pagination_test(conn_id, self.store_2_streams-excepted_streams) |
There was a problem hiding this comment.
Include space as suggested above in line 26
2 tasks
KrisPersonal
approved these changes
Sep 30, 2021
tmck-code
pushed a commit
to lexerdev/tap-shopify
that referenced
this pull request
Feb 3, 2022
* TDL-13587: Added inventory item data stream * TDL-13587: Updated pagination test * TDL-13587: Make pylint happy * TDL-13587: Mkae pylint happy * TDL-13587: Updated the logic of inventory item data collection * TDL-13587: Make pylint happy * TDL-13587: Rmoved white space * TDL-13587: Added inventory_items stream in integration test * TDL-13587: Updated pagination tests for inventory_item * TDL-13587: Added unittests for inventory item data * TDL-13587: Removed typo error * TDL-13587: Updated readme Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added the support of Inventory Item
QA steps
Risks
Rollback steps