Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added NetworkUserHistoryRecent to blacklist #86

Merged
merged 4 commits into from
Aug 26, 2020
Merged

added NetworkUserHistoryRecent to blacklist #86

merged 4 commits into from
Aug 26, 2020

Conversation

jacobrobertbaca
Copy link
Contributor

Description of change

added NetworkUserHistoryRecent to blacklist
https://stitchdata.atlassian.net/secure/RapidBoard.jspa?rapidView=23&modal=detail&selectedIssue=SUP-1797

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
  • ran discovery with cloned connection of client that was previously getting an error that had to do with object not being supported. stream was no longer written to catalog

Risks

  • low

Rollback steps

  • revert this branch

dmosorast
dmosorast requested changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change 👍

tap_salesforce/sync.py Outdated Show resolved Hide resolved
@jacobrobertbaca jacobrobertbaca merged commit c2ec3a5 into master Aug 26, 2020
@jacobrobertbaca jacobrobertbaca deleted the add_NetworkUserHistoryRecent_to_blacklisted_objects branch August 26, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobrobertbaca @dmosorast