Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix related to Batch ID #124

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix related to Batch ID #124

merged 2 commits into from
Oct 25, 2021

Conversation

KrisPersonal
Copy link
Contributor

Description of change

Add BatchID condition as part of the fix

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

dmosorast
dmosorast requested changes Oct 25, 2021
View reviewed changes
tap_salesforce/__init__.py Outdated Show resolved Hide resolved
dmosorast
dmosorast approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@KrisPersonal KrisPersonal merged commit 190c466 into master Oct 25, 2021
@KrisPersonal KrisPersonal deleted the fix-batch-id-null branch October 25, 2021 21:34
@KrisPersonal KrisPersonal mentioned this pull request Oct 25, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrisPersonal @dmosorast