-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema
: Add recurseIntoArrays
option
#960
Schema
: Add recurseIntoArrays
option
#960
Conversation
622dd28
to
2f3f1fe
Compare
I think it makes more sense to add an option to the |
@iamandrewluca @sindresorhus if you agree, I would suggest adding the optional config
|
I will try to refactor it, to be able to use recurseIntoArrays |
Ok, let me know if you need any assistance, I'd be glad to help. |
@grigorischristainas I think I figured it out. Checked other types. I modified the current tests just to check. In the end, I will write separate type tests for this use case. |
2d2c7d1
to
74d62ec
Compare
74d62ec
to
c5bd7a6
Compare
Figured it out with the options. Can't figure out how to make it work )) |
8f422fd
to
f59a2b7
Compare
Thanks @iamandrewluca for the update, I will be able to take a look by the end of day tomorrow, or at the latest on Monday. I could checkout at your branch and commit any changes there. |
@iamandrewluca I cloned your branch ( |
@grigorischristainas invited. If you want you can fork my fork, and open the PR in my fork targeting current branch |
Unfortunately, I cannot fork it because I already have a fork of the original type-fest repository. Maybe I could create a new branch in your forked repo and if you agree with the changes then merge it into yours. |
I invited you as a collaborator in my fork. |
Thanks, I opened a PR to your forked repo with the changes. Please let me know if you need any additional information. |
@grigorischristainas, thanks for the help, I merged your PR. All the changes are visible here now. |
@sindresorhus, just following up to see if there’s any update or feedback on this PR. Please take a look whenever you have some time, thank you! |
Schema
: Add recurseIntoArrays
option
Co-authored-by: Grigoris Christainas <[email protected]>
Allow
Schema
behavior before this PR #887 via Options. Please see PR comments for more context.