Make TupleToUnion support T[] instead of just tuples #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorade
force-pushed
the
update_tuple_to_union
branch
from
058dbdb to
d173e41
Compare
This implementation is simpler which may be more performant. It also works with arrays whereas the previous implementation only worked with tuples.
trevorade
force-pushed
the
update_tuple_to_union
branch
from
d173e41 to
6f9bb49
Compare
|
// @mattmahn |
|
Any clarification you'd like @mattmahn or @sindresorhus? |
skarab42
approved these changes
Nov 5, 2022
|
I just wanted to leave this comment to appreciate that this works now and that you've submitted this PR. Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is no longer recursive which may be more performant. It also works with arrays whereas the previous implementation only worked with tuples.
In addition, it also resolves an issue where infinite tuples were not supported. Previously,
TupleToUnion<[string, ...number[]]>resolved tostringand now it correctly resolves tostring | number.