Add objectEntries()
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahsnider
reviewed
Nov 26, 2021
jonahsnider
approved these changes
Nov 28, 2021
fregante
reviewed
Dec 5, 2021
| ``` | ||
| */ | ||
| export function objectEntries<Type extends Record<PropertyKey, unknown>, Key extends `${Exclude<keyof Type, symbol>}`>(value: Type): Array<[Key, Type[Key]]> { | ||
| return Object.entries(value) as Array<[Key, Type[Key]]>; |
There was a problem hiding this comment.
Why not Entries from type-test?
There was a problem hiding this comment.
Entries of type-fest returns string | number type key. Object.entries stringify string | number key.
We need to discuss whether numeric key must be stringified or not. @jonahsnider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a strongly-typed version of
Object.entries()function.Close #11