Support the use of Node.js as an npm dependency #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help allow users to force a particular node version to be used, even if there is already one on the path.
Common pattern is to use node as a devDependency in an npm package so that everything uses that version of node; if it's present, run-node should probably use that as well. Unless told not to. Which can be done by specifying the RUN_NODE_CACHE_PATH, in which case that file will be sourced to update the PATH. Or, you can do so by having a local .node_path file, which will be sourced if present (and RUN_NODE_CACHE_PATH is not defined).
|
I'm ok with the first two changes, but I don't really want the |
mearns
commented
Nov 17, 2019
|
I believe I made the changes as requested, please let me know if there are any other changes you'd like me to make =) |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common pattern in npm projects is to specify node as a dependency or devDependency in order to make sure that npm scripts are run with the desired node version. Changes in this pull request will prioritize looking for the presence of an installed
./node_modules/nodedependency and use that version if found. I propose that this is the preferred behavior for users, but it is technically breaking backward compatibility because existing uses that happen to have node installed as a dependency will now behave differently.Two other changes are also rolled into this PR, though they could be separated if they aren't desired. One is that if
RUN_NODE_CACHE_PATHis defined and the specified path cache file exists, then it is sourced immediately, instead of waiting to see if node is already found on the existing path. This allows a user to use the env var to override the system path with a custom path cache, which is helpful if their PATH already contains a node executable, but not the one they want to us.The other change is to allow for a local
.node_pathfile which can also be used to override the system path to use a specific node version: if this file is present (andRUN_NODE_CACHE_PATHis not defined), it will likewise be sourced immediately before checking for the presence of a node command.