-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem with calling the browser version concurrently #53
Conversation
That's just a mistake. It should be exported. And it is documented to work like that. Can you properly export it (add it to those exported methods)? |
c1e638e
to
fdb9f7e
Compare
I was not sure what to do with the promise if the request gets canceled. In this implementation, the promise resolves with |
@sindresorhus anything I can do to get this landed? I tested this implementation here. When cancelled, it aborts the current request and prevents the execution of the remaining fallback urls. And it resolves with |
This violates the types and docs though as it's documented to always return a |
The Node.js version throws a |
Done! New sandbox: https://codesandbox.io/s/funny-payne-2qsmo?file=/src/index.js |
Always run |
Thank you :) |
load
callback if multiple requests are done in parallelCloses #52