Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview mode #399

Merged
merged 26 commits into from
Feb 22, 2020
Merged

Add preview mode #399

merged 26 commits into from
Feb 22, 2020

Conversation

TiagoDanin
Copy link
Contributor

Fixes #391

itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/cli.js Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/cli.js Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed May 4, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
@TiagoDanin
Copy link
Contributor Author

image

@itaisteinherz
Copy link
Collaborator

This looks good, though I'm still not sure what the best way to handle #399 (comment) is.

// cc @sindresorhus @SamVerschueren Would love to hear your opinions here.

@itaisteinherz
Copy link
Collaborator

@TiagoDanin It would be great if you could investigate into #391 (comment).

@sindresorhus
Copy link
Owner

This looks good, though I'm still not sure what the best way to handle #399 (comment) is.

The proposed solution there looks good to me.

@TiagoDanin It would be great if you could investigate into #391 (comment).

@TiagoDanin ⬆️

@itaisteinherz
Copy link
Collaborator

One last thing I forgot - this needs to be document in readme.md, both in the Usage section as well as in the Why section.

itaisteinherz
itaisteinherz reviewed Aug 3, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
itaisteinherz
itaisteinherz reviewed Aug 3, 2019
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@itaisteinherz
Copy link
Collaborator

Waiting for @sindresorhus's final review before merging...

sindresorhus
sindresorhus requested changes Sep 13, 2019
View reviewed changes
source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
chinesedfan
chinesedfan requested changes Jan 3, 2020
View reviewed changes
Copy link
Collaborator

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments. Hope will help you.

source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
source/npm/util.js Outdated Show resolved Hide resolved
source/npm/util.js Outdated Show resolved Hide resolved
@TiagoDanin TiagoDanin force-pushed the preview.mode branch 6 times, most recently from 1f7285f to 7037382 Compare January 11, 2020 16:07
@TiagoDanin TiagoDanin mentioned this pull request Jan 11, 2020
Merged
chinesedfan
chinesedfan requested changes Jan 12, 2020
View reviewed changes
Copy link
Collaborator

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are almost there, except for little format problem.

source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
source/npm/publish.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Bump :)

@TiagoDanin
Copy link
Contributor Author

Sorry for the delayed response.

@chinesedfan chinesedfan mentioned this pull request Feb 22, 2020
Merged
@sindresorhus sindresorhus merged commit 5f52e81 into sindresorhus:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaisteinherz itaisteinherz itaisteinherz approved these changes

@chinesedfan chinesedfan chinesedfan approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a --preview flag to dry-run np
4 participants
@TiagoDanin @itaisteinherz @sindresorhus @chinesedfan