Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preid from .npmrc is not respected when drafting the github release #523

Closed
thasmo opened this issue Apr 3, 2020 · 2 comments · Fixed by #547
Closed

preid from .npmrc is not respected when drafting the github release #523

thasmo opened this issue Apr 3, 2020 · 2 comments · Fixed by #547
Labels
enhancement help wanted

Comments

@thasmo
Copy link

thasmo commented Apr 3, 2020

When np opens the release draft in the browser it misses to preselect the correct tag because it does not use the preid configured in the .npmrc file.

So, instead of defining the tag as v1.0.0-rc.0 it populates the tag field with v1.0.0-0, when preid=rc is defined in the .npmrc file.
@dopecodez
Copy link
Collaborator

dopecodez commented Jun 28, 2020 •
edited
Loading

Hey @sindresorhus , is this issue still open? Fix would be to check if .npmrc file had preid option configured, and if so use that tag for any builds when we open the release draft in browser. I'd like to take it up if it is still available

@dopecodez dopecodez mentioned this issue Jul 2, 2020
Merged
@dopecodez
Copy link
Collaborator

Should be implemented with #547

@dopecodez dopecodez linked a pull request Jul 2, 2020 that will close this issue
Respect preId in .npmrc for release tags #547
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect preId in .npmrc for release tags
3 participants
@sindresorhus @thasmo @dopecodez