Respect preId in .npmrc for release tags
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jul 3, 2020
|
Can you give the PR a descriptive title? |
dopecodez
changed the title
preId if available in .npmrc
|
I also missed adding a condition to only add the |
sindresorhus
changed the title
preId if available in .npmrcpreId in .npmrc for release tags
|
Looks good 👍🏻 |
|
I raised another PR #546 too, @sindresorhus . It'd be great if you took a look at that when you got the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523 . Additionally, has unit tests for the new function introduced to get
preIdif available.Tested on MacOS10.13.6.