Fix error "glob pattern string required" (#616)

Co-authored-by: Itai Steinherz <[email protected]> Co-authored-by: Sindre Sorhus <[email protected]>
sindresorhus · Mar 19, 2022 · 9cff6da · 9cff6da
1 parent 20117a4
commit 9cff6da
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/integration-test b/integration-test
diff --git a/source/npm/util.js b/source/npm/util.js
@@ -167,6 +167,10 @@ async function getFilesIgnoredByDotnpmignore(pkg, fileList) {
 }
 
 function filterFileList(globArray, fileList) {
+	if (globArray.length === 0) {
+		return [];
+	}
+
 	const globString = globArray.length > 1 ? `{${globArray.filter(singlePath => excludeGitAndNodeModulesPaths(singlePath))}}` : globArray[0];
 	return fileList.filter(minimatch.filter(globString, {matchBase: true, dot: true})); // eslint-disable-line unicorn/no-fn-reference-in-iterator
 }

diff --git a/test/npmignore.js b/test/npmignore.js
@@ -152,3 +152,23 @@ test('first time published files - ignore strategy is not used', async t => {
 	});
 	t.deepEqual(await testedModule.getFirstTimePublishedFiles({name: 'no ignore strategy'}, newFiles), ['source/ignore.txt', 'source/pay_attention.txt', 'test/file.txt']);
 });
+
+test('first time published files - empty files property', async t => {
+	const testedModule = proxyquire('../source/npm/util', {
+		'pkg-dir':
+			{
+				sync: () => path.resolve('test', 'fixtures', 'package')
+			}
+	});
+	t.deepEqual(await testedModule.getFirstTimePublishedFiles({files: []}, newFiles), []);
+});
+
+test('first time published files - .npmignore excludes everything', async t => {
+	const testedModule = proxyquire('../source/npm/util', {
+		'pkg-dir':
+			{
+				sync: () => path.resolve('test', 'fixtures', 'npmignore')
+			}
+	});
+	t.deepEqual(await testedModule.getFirstTimePublishedFiles({name: 'excluded everything'}, ['source/ignore.txt']), []);
+});