Run CI on Windows #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: | ||
| - 22 | ||
| - 20 |
There was a problem hiding this comment.
Yes. To reduce the number of CI jobs since it is unlikely for a bug to be present in Node 20 but neither in Node 18 nor Node 22.
We can leave it though if you prefer?
There was a problem hiding this comment.
Nah, it's fine. Was just curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12.
This does not completely fix #12 yet, since we still need to add more tests of things that could fail on Windows (shebangs, etc.), but we can do this in a separate PR.